excel - VBA, importing large data from multiple workbooks into mastersheet -


my code opens file picker , selects files , particular column im interested in combining master worksheet.

i pick several .csv files , bring in column of choosing .

issue have are,

1) these files large, 400kb.

2) run time error 1004, copy area , paste area not same size , shape. running out of space on excel sheet? when debug error on line copyrng.copy destrng

my end goal see , count , see unique values col c(perhaps other columns) workbooks.

option explicit dim wsmaster workbook, csvfiles workbook dim filename string dim file integer dim r long  public sub consolidate()      application         .screenupdating = false         .enableevents = false     end      application.filedialog(msofiledialogopen)         .allowmultiselect = true         .title = "select files process"         .show          if .selecteditems.count = 0 exit sub          set wsmaster = activeworkbook  dim copyrng range, destrng range dim firstrow long file = 1 .selecteditems.count      filename = .selecteditems.item(file)      if right(filename, 4) = ".csv"         set csvfiles = workbooks.open(filename, 0, true)         r = wsmaster.sheets("sheet1").range("c" & rows.count).end(xlup).row         '' main new part         set copyrng = csvfiles.sheets(1).range("c1:c" & r)         wsmaster.sheets("sheet1")             firstrow = .cells(.rows.count, 2).end(xlup).row             set destrng = .range("a" & firstrow + 1).offset(0, 1)         end          copyrng.copy destrng         ''''''''''         csvfiles.close savechanges:=false    'close without saving     end if next file      end      set wsmaster = nothing     set csvfiles = nothing      application         .screenupdating = true         .enableevents = true      end  end sub

updated code below recommendation

option explicit dim wsmaster workbook, csvfiles workbook dim filename string dim file integer dim r long  public sub consolidate()      application         .screenupdating = false         .enableevents = false     end      application.filedialog(msofiledialogopen)         .allowmultiselect = true         .title = "select files process"         .show          if .selecteditems.count = 0 exit sub          set wsmaster = activeworkbook  dim copyrng range, destrng range dim firstrow long file = 1 .selecteditems.count      filename = .selecteditems.item(file)         if right(filename, 4) = ".csv"     set csvfiles = workbooks.open(filename, 0, true)     r = csvfiles.sheets(1).range("c" & rows.count).end(xlup).row     '' main new part     set copyrng = csvfiles.sheets(1).range("c1:c" & r)     wsmaster.sheets("sheet1")         firstrow = .cells(.rows.count, 2).end(xlup).row + 1         set destrng = .range("b" & firstrow & "b" & (firstrow + r))     end      destrng.value = copyrng.value     ''''''''''     csvfiles.close savechanges:=false    'close without saving end if   next file      end      set wsmaster = nothing     set csvfiles = nothing      application         .screenupdating = true         .enableevents = true      end  end sub

since number of rows defined r can set dimensions of destination range. change below should fix copy-paste error , speed code eliminating use of clipboard (assuming want values copied).

if right(filename, 4) = ".csv"     set csvfiles = workbooks.open(filename, 0, true)     r = csvfiles.sheets(1).range("c" & rows.count).end(xlup).row     '' main new part     set copyrng = csvfiles.sheets(1).range("c1:c" & r)     wsmaster.sheets("sheet1")         firstrow = .cells(.rows.count, 2).end(xlup).row + 1         set destrng = .range("b" & firstrow & ":b" & (firstrow + r))     end      destrng.value = copyrng.value     ''''''''''     csvfiles.close savechanges:=false    'close without saving end if

Comments

Post a Comment

Popular posts from this blog

android - InAppBilling registering BroadcastReceiver in AndroidManifest -

i'm implementing inapp billing in android app. works well, however, i'm trying decouple broadcast receiver activity manifest. suggestion in android's trivialdrive sample: // important: dynamically register broadcast messages updated purchases. // register receiver here instead of <receiver> in manifest // because call getpurchases() @ startup, therefore can ignore // broadcasts sent while app isn't running. // note: registering listener in activity bad idea, done here // because sample. regardless, receiver must registered after // iabhelper setup, before first call getpurchases(). currently there's class extends broadcastreceiver : public class iabbroadcastreceiver extends broadcastreceiver { /** * intent action receiver should filter for. */ public static final string action = "com.android.vending.billing.purchases_updated"; private final iabbroadcastlistener mlistener; public iabbroadcastreceiver(iabbroadcastlistener listener) { m...
Read more

python Tkinter Capturing keyboard events save as one single string -

is possible store keyboard events 1 string? code below stores 1 char , prints it. card reader or bar code reader, contains collection of character/ string not 1 character @ time. goal save char pressed text variable. from tkinter import * root = tk() def key(event): text= event.char text+= event.char print ("pressed", text) def callback(event): frame.focus_set() print ("clicked at", event.x, event.y) frame = frame(root, width=100, height=100) frame.bind("<key>", key) frame.bind("<button-1>", callback) frame.pack() root.mainloop() currently, creating text variable , everytime key() function gets called, , text stores last character typed. you can define text module level variable , , use module level text inside key function - text = '' def key(event): global text text+= event.char print("pressed", text)
Read more

sql server - Why does Linq-to-SQL add unnecessary COUNT()? -

here tables: create table customer ( cid int primary key, name varchar(32) ) create table ord ( oid int primary key, cid int foreign key references customer, address varchar(20) ) here's linq-to-sql statement: var aaa = c in db.customer select new { c, o = c.ord.tolist() }; and here's inexplicable query generated linq-to-sql: select [t0].[cid] [cid], [t0].[name] [name], [t1].[oid] [oid], [t1].[cid] [cid2], [t1].[address] [address], (select count(*) [dbo].[ord] [t2] [t2].[cid] = [t0].[cid]) [value] [dbo].[customer] [t0] left outer join [dbo].[ord] [t1] on [t1].[cid] = [t0].[cid] order [t0].[cid], [t1].[oid] i want understand how rid of count(*) part. it's entirely uncalled for! linq needs count(*) in order determine number of entries returned o = c.ord.tolist() .
Read more