windows - If statement in batch file doesn't execute(Possible syntax issue?) -


i using below script automate processes make work life easier. when running current version faults out , closes program right first if statement executes. did quite bit of research on own , code looks correct. program closed fast couldn't read reason why. ran output txt file. looks if program faults out syntax reason. unfortunately don't have file me , don't have exact error. can post tomorrow when in front of me.

::turns off unnecessary messages command prompt echo off  ::copies files on nas drive required setup echo transfering files nas1... if not exist "%userprofile%\desktop\install_files" mkdir %userprofile%\desktop\install_files xcopy /y \\nas1\volume_1\"tech department"\"general windows  pos preperation"\* "%userprofile%\desktop\install_files" echo file transfer complete  ::start installation of foxit reader echo installing foxit reader... start /w %userprofile%\desktop\install_files\"foxitreader831_current version".exe echo installations complete  ::changes background changing file pathway in registry value echo setting background... reg add "hkcu\control panel\desktop" /v wallpaper /t reg_sz /d %userprofile%\desktop\install_files\newtms1024x768.jpg /f  ::changes workgroup , computer name echo setting computer name... set /p pcname=please enter computer name:  wmic computersystem "name='%computername%'" rename "%pcname%"  echo setting workgroup... set /p wgname=please enter workgroup name: wmic computersystem name="%computername%" call joindomainorworkgroup name="%wgname%"  ::selecting pos software install set /p posname=please enter pos software install (a:aldelo m:mapos t:trpos):  if /i %posname% == "m" (    ::transfers required files nas drive install folder    echo transferring install files...    xcopy /y \\nas1\volume_1\"tech department"\"pos software"\mapos\* "%userprofile%\desktop\install_files"      ::installs mapos , groovv sdk card processing     echo installing groovvsdk...     start /w %userprofile%\desktop\install_files\groovvsdk_client_setup_v3.9.6      echo installing mapos...     start /w %userprofile%\desktop\install_files\mapos_install )  if /i %posname% == "t" (     ::transfers required install file trpos     echo transferring install files...     xcopy /y \\nas1\volume_1\"tech department"\"pos software"\trpos\trpos_install.exe "%userprofile%\desktop\install_files"      ::installs trpos     start /w %userprofile%\desktop\install_files\trpos_install.exe )  if  /i %posname% == "a" ( ) else (     echo no pos software selected or improper input )  ::force restarts computer changes take effect ::shutdown.exe /r /t 00

there 2 problems ifs

the first 1 related how parser handles commands. line

if %posname% == "m"

is not comparing value inside variable against literal string. happening parser expands variable reference (%posname%) replacing reference value inside command , tries execute resulting command, without variable reference, value. so, expected values stored in posname variable, command executed , result 

if %posname% == "m"  value                  parsed            result -------------------------------------------------------------- postname empty ->   if == "m"            syntax error  postname     ->   if == "a"          false postname m     ->   if m == "m"          false

in first case command fails because there not value in left side of == operator. variable empty , nothing can placed in command executed.

the second case seems logical, third case not obvious. why false? because value in right side of == quoted literal while value in left side unquoted literal, both values not match.

you can solve problem quoting both sides

if "%posname%"=="m"   value                  parsed            result -------------------------------------------------------------- postname empty ->   if "" == "m"           false postname     ->   if "a" == "a"          false postname m     ->   if "m" == "m"          true

(note: can unquote both sides, not recommended unless sure values on both sides , resulting command not generate problems)

the second problem in code parenthesis placement. batch syntax requires them placed:

  • if present, opening parenthesis in if clause must in same line contains if

  • if there else clause closing if parenthesis must in else line.

  • if there else opening parenthesis, must in else line

so, this

if "%posname%"=="m"  (     ..... )

is not valid syntax. can see here samples of how place parenthesis.


Comments

Post a Comment

Popular posts from this blog

android - InAppBilling registering BroadcastReceiver in AndroidManifest -

i'm implementing inapp billing in android app. works well, however, i'm trying decouple broadcast receiver activity manifest. suggestion in android's trivialdrive sample: // important: dynamically register broadcast messages updated purchases. // register receiver here instead of <receiver> in manifest // because call getpurchases() @ startup, therefore can ignore // broadcasts sent while app isn't running. // note: registering listener in activity bad idea, done here // because sample. regardless, receiver must registered after // iabhelper setup, before first call getpurchases(). currently there's class extends broadcastreceiver : public class iabbroadcastreceiver extends broadcastreceiver { /** * intent action receiver should filter for. */ public static final string action = "com.android.vending.billing.purchases_updated"; private final iabbroadcastlistener mlistener; public iabbroadcastreceiver(iabbroadcastlistener listener) { m...
Read more

python Tkinter Capturing keyboard events save as one single string -

is possible store keyboard events 1 string? code below stores 1 char , prints it. card reader or bar code reader, contains collection of character/ string not 1 character @ time. goal save char pressed text variable. from tkinter import * root = tk() def key(event): text= event.char text+= event.char print ("pressed", text) def callback(event): frame.focus_set() print ("clicked at", event.x, event.y) frame = frame(root, width=100, height=100) frame.bind("<key>", key) frame.bind("<button-1>", callback) frame.pack() root.mainloop() currently, creating text variable , everytime key() function gets called, , text stores last character typed. you can define text module level variable , , use module level text inside key function - text = '' def key(event): global text text+= event.char print("pressed", text)
Read more

sql server - Why does Linq-to-SQL add unnecessary COUNT()? -

here tables: create table customer ( cid int primary key, name varchar(32) ) create table ord ( oid int primary key, cid int foreign key references customer, address varchar(20) ) here's linq-to-sql statement: var aaa = c in db.customer select new { c, o = c.ord.tolist() }; and here's inexplicable query generated linq-to-sql: select [t0].[cid] [cid], [t0].[name] [name], [t1].[oid] [oid], [t1].[cid] [cid2], [t1].[address] [address], (select count(*) [dbo].[ord] [t2] [t2].[cid] = [t0].[cid]) [value] [dbo].[customer] [t0] left outer join [dbo].[ord] [t1] on [t1].[cid] = [t0].[cid] order [t0].[cid], [t1].[oid] i want understand how rid of count(*) part. it's entirely uncalled for! linq needs count(*) in order determine number of entries returned o = c.ord.tolist() .
Read more