wpf - Do I need to use DI and IoC everytime ModelView uses Model in MVVM? -


i'm new .net mvvm structure of application , have basic knowledge of it's principles, decoupling, bindings, commands , etc. i'm using mvvm light framework simplify common mvvm issues messaging , service location.

one thing don't understand: need call simpleioc every time using model classes viewmodel? example: have simple view, viewmodel corresponding , model 1 class settings.

mainwindow.xaml

<window ...>     <window.resources>         <viewmodels:mainwindowmodel x:key="viewmodel" />     </window.resources>     <dockpanel datacontext="{staticresource viewmodel}">         <button command="{binding dosomecommand}" />     </dockpanel> </window>

mainwindowmodel.cs

public class mainwindowmodel: inotifypropertychanged {     public event propertychangedeventhandler propertychanged;     public icommand dosomecommand { get; private set; }      protected void raisepropertychangedevent(string propertyname)     {         propertychanged?.invoke(this, new propertychangedeventargs(propertyname));     }      public mainwindowmodel()     {         dosomecommand = new relaycommand(dosome);     }      public void dosome()     {         var data = settings.instance;  //singleton          //... data ...          debug.log($"{data.prop1}, {data.prop2}, {data.prop3}");     } }

settings.cs

public static class settings  {     //... singleton implementations ...      public int prop1 { get; set; } // implementation of getters , setters             public int prop2 { get; set; }      public int prop3 { get; set; }   }

this code has 1 huge disadvantage: dosome() method not unit-testable. ok, let's fix that:

public class mainwindowmodel: inotifypropertychanged {      //...      private settings _data;       public mainwindowmodel()       {           _data = settings.instance;           dosomecommand = new relaycommand(() => dosome(_data));      }       public void dosome(settings data)      {            //... data ...           debug.log($"{data.prop1}, {data.prop2}, {data.prop3}");      } }

now can mock or stub settings class , test dosome().

but know 'settings' class in different implementations, 'settingsxml' (data xml), 'settingsregistry' (data window registry), 'settingsini' (data ini-file, wierd, true). avoid potential problems rewrote in interfaces:

public interface isettings {     public int prop1;     public int prop2;     public int prop3; }   public static class settings: isettings  {     //... singleton implementations ...      public int prop1 { get; set; } // implementation of getters , setters             public int prop2 { get; set; }      public int prop3 { get; set; }   }  public class mainwindowmodel: inotifypropertychanged {      //...      private isettings _data;       public void dosome(isettings data)      {            ... data ...           debug.log($"_data.prop1}, {data.prop2}, {data.prop3}");      }  }

everything looks fine me. dosome() testable , settings implementation different. 1 thing bothers me: mainwindowmodel knows actual class of settings (_data = settings.instance).

is ok in mvvm structure?

is necessary use ioc, write 'settingswrapper' class dependency injection of isettings class , use _data = simpleioc.default.getinstance<settingswrapper>?

what should if settings class not singleton?

sorry, if got basic idea of di , ioc wrong. appreciate, if correct me.

one thing bothers me: mainwindowmodel knows actual class of settings (_data = settings.instance).

it shouldn't. should know interface getting injecting with.

instead of passing isettings object dosome method, inject mainwindowmodel class isettings when create it:

public mainwindowmodel(isettings settings) { ... }

you let viewmodellocator taking care of creating view model class:

public class viewmodellocator {     public viewmodellocator()     {         servicelocator.setlocatorprovider(() => simpleioc.default);          simpleioc.default.register<isettings>(() => settings.instance);         simpleioc.default.register<mainviewmodel>();     }      public mainviewmodel main     {                 {             return servicelocator.current.getinstance<mainviewmodel>();         }     } } 
<dockpanel datacontext="{binding main, source={staticresource locator}}">     <button command="{binding dosomecommand}" /> </dockpanel>

Comments

Post a Comment

Popular posts from this blog

android - InAppBilling registering BroadcastReceiver in AndroidManifest -

i'm implementing inapp billing in android app. works well, however, i'm trying decouple broadcast receiver activity manifest. suggestion in android's trivialdrive sample: // important: dynamically register broadcast messages updated purchases. // register receiver here instead of <receiver> in manifest // because call getpurchases() @ startup, therefore can ignore // broadcasts sent while app isn't running. // note: registering listener in activity bad idea, done here // because sample. regardless, receiver must registered after // iabhelper setup, before first call getpurchases(). currently there's class extends broadcastreceiver : public class iabbroadcastreceiver extends broadcastreceiver { /** * intent action receiver should filter for. */ public static final string action = "com.android.vending.billing.purchases_updated"; private final iabbroadcastlistener mlistener; public iabbroadcastreceiver(iabbroadcastlistener listener) { m...
Read more

python Tkinter Capturing keyboard events save as one single string -

is possible store keyboard events 1 string? code below stores 1 char , prints it. card reader or bar code reader, contains collection of character/ string not 1 character @ time. goal save char pressed text variable. from tkinter import * root = tk() def key(event): text= event.char text+= event.char print ("pressed", text) def callback(event): frame.focus_set() print ("clicked at", event.x, event.y) frame = frame(root, width=100, height=100) frame.bind("<key>", key) frame.bind("<button-1>", callback) frame.pack() root.mainloop() currently, creating text variable , everytime key() function gets called, , text stores last character typed. you can define text module level variable , , use module level text inside key function - text = '' def key(event): global text text+= event.char print("pressed", text)
Read more

sql server - Why does Linq-to-SQL add unnecessary COUNT()? -

here tables: create table customer ( cid int primary key, name varchar(32) ) create table ord ( oid int primary key, cid int foreign key references customer, address varchar(20) ) here's linq-to-sql statement: var aaa = c in db.customer select new { c, o = c.ord.tolist() }; and here's inexplicable query generated linq-to-sql: select [t0].[cid] [cid], [t0].[name] [name], [t1].[oid] [oid], [t1].[cid] [cid2], [t1].[address] [address], (select count(*) [dbo].[ord] [t2] [t2].[cid] = [t0].[cid]) [value] [dbo].[customer] [t0] left outer join [dbo].[ord] [t1] on [t1].[cid] = [t0].[cid] order [t0].[cid], [t1].[oid] i want understand how rid of count(*) part. it's entirely uncalled for! linq needs count(*) in order determine number of entries returned o = c.ord.tolist() .
Read more