Overriding the java equals() method quirk -


i ran interesting (and frustrating) issue equals() method today caused thought tested class crash , cause bug took me long time track down.

just completeness, wasn't using ide or debugger - old fashioned text editor , system.out's. time limited , school project.

anyhow -

i developing basic shopping cart contain arraylist of book objects. in order implement addbook(), removebook(), , hasbook() methods of cart, wanted check if book existed in cart. off go -

public boolean equals(book b) {     ... // more code here - null checks     if (b.getid() == this.getid()) return true;     else return false; }

all works fine in testing. create 6 objects , fill them data. many adds, removes, has() operations on cart , works fine. read can either have equals(type var) or equals(object o) { (cast) var } assumed since working, didn't matter much.

then ran problem - needed create book object id in within book class. no other data entered it. following:

public boolean hasbook(int i) {     book b = new book(i);     return hasbook(b); }  public boolean hasbook(book b) {     // .. more code here     return this.books.contains(b); }

all of sudden, equals(book b) method no longer works. took long time track down without debugger , assuming cart class tested , correct. after swaapping equals() method following:

public boolean equals(object o) {     book b = (book) o;     ... // rest goes here    }

everything began work again. there reason method decided not take book parameter though book object? difference seemed instantiated within same class, , filled 1 data member. i'm very confused. please, shed light?

in java, equals() method inherited object is:

public boolean equals(object other);

in other words, parameter must of type object.

the arraylist uses correct equals method, calling 1 didn't override object's equals.

not overriding method correctly can cause problems.

i override equals following everytime:

@override public boolean equals(object other){     if (other == null) return false;     if (other == this) return true;     if (!(other instanceof myclass))return false;     myclass othermyclass = (myclass)other;     ...test other properties here... }

the use of @override annotation can ton silly mistakes.

use whenever think overriding super class' or interface's method. way, if wrong compile error.


Comments

Post a Comment

Popular posts from this blog

android - InAppBilling registering BroadcastReceiver in AndroidManifest -

i'm implementing inapp billing in android app. works well, however, i'm trying decouple broadcast receiver activity manifest. suggestion in android's trivialdrive sample: // important: dynamically register broadcast messages updated purchases. // register receiver here instead of <receiver> in manifest // because call getpurchases() @ startup, therefore can ignore // broadcasts sent while app isn't running. // note: registering listener in activity bad idea, done here // because sample. regardless, receiver must registered after // iabhelper setup, before first call getpurchases(). currently there's class extends broadcastreceiver : public class iabbroadcastreceiver extends broadcastreceiver { /** * intent action receiver should filter for. */ public static final string action = "com.android.vending.billing.purchases_updated"; private final iabbroadcastlistener mlistener; public iabbroadcastreceiver(iabbroadcastlistener listener) { m...
Read more

python Tkinter Capturing keyboard events save as one single string -

is possible store keyboard events 1 string? code below stores 1 char , prints it. card reader or bar code reader, contains collection of character/ string not 1 character @ time. goal save char pressed text variable. from tkinter import * root = tk() def key(event): text= event.char text+= event.char print ("pressed", text) def callback(event): frame.focus_set() print ("clicked at", event.x, event.y) frame = frame(root, width=100, height=100) frame.bind("<key>", key) frame.bind("<button-1>", callback) frame.pack() root.mainloop() currently, creating text variable , everytime key() function gets called, , text stores last character typed. you can define text module level variable , , use module level text inside key function - text = '' def key(event): global text text+= event.char print("pressed", text)
Read more

sql server - Why does Linq-to-SQL add unnecessary COUNT()? -

here tables: create table customer ( cid int primary key, name varchar(32) ) create table ord ( oid int primary key, cid int foreign key references customer, address varchar(20) ) here's linq-to-sql statement: var aaa = c in db.customer select new { c, o = c.ord.tolist() }; and here's inexplicable query generated linq-to-sql: select [t0].[cid] [cid], [t0].[name] [name], [t1].[oid] [oid], [t1].[cid] [cid2], [t1].[address] [address], (select count(*) [dbo].[ord] [t2] [t2].[cid] = [t0].[cid]) [value] [dbo].[customer] [t0] left outer join [dbo].[ord] [t1] on [t1].[cid] = [t0].[cid] order [t0].[cid], [t1].[oid] i want understand how rid of count(*) part. it's entirely uncalled for! linq needs count(*) in order determine number of entries returned o = c.ord.tolist() .
Read more