python - I keep getting "ValueError: list.remove(x): x not in list" when looping through nested lists -


this question has answer here:

i trying make simple version of space invaders, keep running same error

valueerror: list.remove(x): x not in list

trying remove invaders once they've been hit.

here code.

def killenemies(bullets, enemies):     bullet in bullets:         x in enemies:             y in x:                 if bullet.top <= y.bottom , bullet.top >= y.top:                     if bullet.left >= y.left , bullet.right <= y.right:                         x.remove(y)                         bullets.remove(bullet)

the problem occurs when if statements true, , console says error occurs in last line

here rest of code

import pygame, sys pygame.locals import *   pygame.init()  fps = 30 fpsclock = pygame.time.clock()  displaysurf = pygame.display.set_mode((800, 660), 0, 32) pygame.display.set_caption('space invaders')  white = (255, 255, 255) black = (0, 0, 0) shipx = 50 shipy = 630 displaysurf.fill(black)  timer = fpsclock.tick() time = 0 direction = '' bullets = [] bulletx = shipx + 25 bullety = shipy - 50 enemies = [[], [], [], [], [], [], []] shields = []   def drawenemies(enemies):     y = 0     n in enemies:         x = 0         f in range(7):             enemy = pygame.draw.rect(displaysurf, white, (30 + x, 40 + y, 75, 20))             n.append(enemy)             x += 110         y += 30     return enemies  def killenemies(bullets, enemies):     bullet in bullets:         x in enemies:             y in x:                 if bullet.top <= y.bottom , bullet.top >= y.top:                     if bullet.left >= y.left , bullet.right <= y.right:                     x.remove(y)                     bullets.remove(bullet)   def movebullets(bullets):     bullet in bullets:          bullet.top -= 15     b in bullets:         pygame.draw.rect(displaysurf, white, b)  while true:       if direction == 'left':         shipx -= 8         bulletx -= 8     elif direction == 'right':         shipx += 8         bulletx += 8       event in pygame.event.get():         if event.type == quit:             pygame.quit()             sys.exit()          key = pygame.key.get_pressed()          if key[k_left]:             direction = 'left'         elif key[k_right]:             direction = 'right'         elif key[k_space]:             bullet = pygame.draw.line(displaysurf, white, (bulletx, bullety), (bulletx, bullety - 25), 2)             bullets.append(bullet)          if event.type == keyup:             direction = ''      time += timer             displaysurf.fill(black)     pygame.draw.polygon(displaysurf, white, ((shipx, shipy), (shipx + 25, shipy - 50), (shipx + 50, shipy)), 1)     drawenemies(enemies)     movebullets(bullets)     killenemies(bullets, enemies)     pygame.display.update()     fpsclock.tick(fps)

you should not try , mutate list while iterating on it. source of issues.

for simple example, try running:

some_list = [1,2,3,4] x in some_list:     some_list.remove(x) print(some_list) # prints [2, 4]

obviously not expected outcome - perhaps expect entire list empty.

the solution either use list comprehension create new list required elements, or make copy of list iterate over. if go route of creating copy, simple as:

def killenemies(bullets, enemies):     bullet in bullets[:]:         x in enemies:             y in x[:]:                 if bullet.top <= y.bottom , bullet.top >= y.top:                     if bullet.left >= y.left , bullet.right <= y.right:                         x.remove(y)                         bullets.remove(bullet)

note list[:] creates shallow copy of list, , hence underlying objects in original list , copied list should same.

the other issue having in logic of for loops. each bullet, iterating on multiple enemies, , need break out of 2 inner loops once each bullet 'spent'. written, seems trying remove each bullet multiple times. suggest code refactoring in order here:

def killenemies(bullets, enemies):     bullet in bullets[:]:         iterenemies(bullets, bullet, enemies)  def iterenemies(bullets, bullet, enemies):     x in enemies:         y in x[:]:             if bullet.top <= y.bottom , bullet.top >= y.top:                 if bullet.left >= y.left , bullet.right <= y.right:                     x.remove(y)                     bullets.remove(bullet)                     return

Comments

Post a Comment

Popular posts from this blog

android - InAppBilling registering BroadcastReceiver in AndroidManifest -

i'm implementing inapp billing in android app. works well, however, i'm trying decouple broadcast receiver activity manifest. suggestion in android's trivialdrive sample: // important: dynamically register broadcast messages updated purchases. // register receiver here instead of <receiver> in manifest // because call getpurchases() @ startup, therefore can ignore // broadcasts sent while app isn't running. // note: registering listener in activity bad idea, done here // because sample. regardless, receiver must registered after // iabhelper setup, before first call getpurchases(). currently there's class extends broadcastreceiver : public class iabbroadcastreceiver extends broadcastreceiver { /** * intent action receiver should filter for. */ public static final string action = "com.android.vending.billing.purchases_updated"; private final iabbroadcastlistener mlistener; public iabbroadcastreceiver(iabbroadcastlistener listener) { m...
Read more

python Tkinter Capturing keyboard events save as one single string -

is possible store keyboard events 1 string? code below stores 1 char , prints it. card reader or bar code reader, contains collection of character/ string not 1 character @ time. goal save char pressed text variable. from tkinter import * root = tk() def key(event): text= event.char text+= event.char print ("pressed", text) def callback(event): frame.focus_set() print ("clicked at", event.x, event.y) frame = frame(root, width=100, height=100) frame.bind("<key>", key) frame.bind("<button-1>", callback) frame.pack() root.mainloop() currently, creating text variable , everytime key() function gets called, , text stores last character typed. you can define text module level variable , , use module level text inside key function - text = '' def key(event): global text text+= event.char print("pressed", text)
Read more

sql server - Why does Linq-to-SQL add unnecessary COUNT()? -

here tables: create table customer ( cid int primary key, name varchar(32) ) create table ord ( oid int primary key, cid int foreign key references customer, address varchar(20) ) here's linq-to-sql statement: var aaa = c in db.customer select new { c, o = c.ord.tolist() }; and here's inexplicable query generated linq-to-sql: select [t0].[cid] [cid], [t0].[name] [name], [t1].[oid] [oid], [t1].[cid] [cid2], [t1].[address] [address], (select count(*) [dbo].[ord] [t2] [t2].[cid] = [t0].[cid]) [value] [dbo].[customer] [t0] left outer join [dbo].[ord] [t1] on [t1].[cid] = [t0].[cid] order [t0].[cid], [t1].[oid] i want understand how rid of count(*) part. it's entirely uncalled for! linq needs count(*) in order determine number of entries returned o = c.ord.tolist() .
Read more