ruby on rails - How do you name a function which turns other Boolean value to true? -


i have model , model has several attributes. want turn 1 of boolean attributes true based on other attributes.

let's have model called user , user has attributes like..

  • id (int)
  • name (text)
  • birthday (date)
  • legal_age (boolean)

i asked change legal age attribute, based on birthday. (if user 20 years old turn true, if not, keep false.) named function check_legal_age, because checks legal age column true.

however, 1 of colleagues advised me name vague , hard figure out function , kind of value function returns.

after conversation, decided name function make_legal_age_true, wordy straight-forward name. colleague suggested me name trufy_legal_age

is there conventional way name method makes intentions clear others reading code?

your colleague right check_legal_age not name, not because it's vague, per se, because it's misleading , therefore dangerous. seems imply object state being checked or validated, when in fact it's being altered.

convention method changes internal object state should "bang" ! method. naming method legal_age! gets point across setting boolean attribute true.

better if predicate method (the 1 returns true or false) ended ?. legal_age? , legal_age! seem crystal clear me.


Comments

Post a Comment

Popular posts from this blog

python Tkinter Capturing keyboard events save as one single string -

is possible store keyboard events 1 string? code below stores 1 char , prints it. card reader or bar code reader, contains collection of character/ string not 1 character @ time. goal save char pressed text variable. from tkinter import * root = tk() def key(event): text= event.char text+= event.char print ("pressed", text) def callback(event): frame.focus_set() print ("clicked at", event.x, event.y) frame = frame(root, width=100, height=100) frame.bind("<key>", key) frame.bind("<button-1>", callback) frame.pack() root.mainloop() currently, creating text variable , everytime key() function gets called, , text stores last character typed. you can define text module level variable , , use module level text inside key function - text = '' def key(event): global text text+= event.char print("pressed", text)
Read more

android - InAppBilling registering BroadcastReceiver in AndroidManifest -

i'm implementing inapp billing in android app. works well, however, i'm trying decouple broadcast receiver activity manifest. suggestion in android's trivialdrive sample: // important: dynamically register broadcast messages updated purchases. // register receiver here instead of <receiver> in manifest // because call getpurchases() @ startup, therefore can ignore // broadcasts sent while app isn't running. // note: registering listener in activity bad idea, done here // because sample. regardless, receiver must registered after // iabhelper setup, before first call getpurchases(). currently there's class extends broadcastreceiver : public class iabbroadcastreceiver extends broadcastreceiver { /** * intent action receiver should filter for. */ public static final string action = "com.android.vending.billing.purchases_updated"; private final iabbroadcastlistener mlistener; public iabbroadcastreceiver(iabbroadcastlistener listener) { m
Read more

javascript - Z-index in d3.js -

i have map , when hover effect on region of map below yellow line , circle, last ones disappear. how can solve problem? http://jsfiddle.net/ot21n9qx/ var arc = g.append("path") .style("fill", "none") .style("stroke", "yellow") .style("stroke-width", 2) .attr("d", "m" + pathorigin[0] + "," + pathorigin[1] + " q" + svgpoint[0] + "," + pathorigin[1] + " " + svgpoint[0] + "," + svgpoint[1]); var circlesize = d3.scale.linear() .domain([0, 0.5, 1]) .range([4, 10, 4]); svg not have z order draws objects in order created. need create path , circle after create highlight regions. here forked fiddle: http://jsfiddle.net/o00fzgaf/1/
Read more